[wasm] Remove explicit WasmBootConfigFileName from tests #47759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the explicit configuration of WasmBootConfigFileName from tests, relying on the new default provided by the dotnet.boot.js changes in the runtime and SDK.
- Removed the hard-coded WasmBootConfigFileName configuration block in the test asset setup.
- Simplified the test configuration for AspNetSdkTest.
ilonatommy
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to have dotnet.boot.js as a default boot config flown from runtime to sdk. We can remove the explicit configuration from all tests.
Contributes to dotnet/aspnetcore#59456