Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow winforms binaries in the VMR #47745

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow winforms binaries in the VMR #47745

wants to merge 2 commits into from

Conversation

ellahathaway
Copy link
Member

@Copilot Copilot bot review requested due to automatic review settings March 19, 2025 22:54
@ellahathaway ellahathaway requested review from a team as code owners March 19, 2025 22:54
Copilot
Copilot AI reviewed Mar 19, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/SourceBuild/content/eng/allowed-vmr-binaries.txt: Language not supported
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Mar 19, 2025
mthalman
mthalman reviewed Mar 20, 2025
View reviewed changes
src/SourceBuild/content/eng/allowed-vmr-binaries.txt Outdated
src/winforms/src/test/integration/MauiTests/lib/*.dll
src/winforms/src/test/integration/WinformsControlsTest/Resources/media.mpg
src/winforms/src/test/unit/System.Windows.Forms/bitmaps/milkmateya01.emf
src/winforms/src/test/unit/System.Windows.Forms/bitmaps/telescope_01.wmf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have src/winforms/src/System.Windows.Forms*/**/*.wmf. Should that be broadened in scope so we don't need to have this entry as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 7675163

@ellahathaway ellahathaway requested a review from mthalman March 20, 2025 18:33
@ellahathaway ellahathaway enabled auto-merge (squash) March 20, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[main] New winforms binaries in VMR
4 participants
@ellahathaway @jkoritzinsky @ViktorHofer @mthalman