-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StaticWebAssets] Adds incrementalism to DefineStaticWebAssets #47701
[StaticWebAssets] Adds incrementalism to DefineStaticWebAssets #47701
Conversation
Thanks for your PR, @javiercn. |
c08b2e7
to
fd9b5f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
fd9b5f8
to
afbff6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think I have too many comments right now for me to approve, but I'm not anticipating many changes will need to be made. Most comments are seeking clarification.
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.JSModules.targets
Show resolved
Hide resolved
afbff6e
to
63f2610
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
a8dab71
to
08f002b
Compare
* Makes the task incremental and retrieves the results from a cache to avoid hitting disk to compute integrity and fingerprint on incremental builds
This shaves another ~600ms on builds