Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StaticWebAssets] Adds incrementalism to DefineStaticWebAssets #47701

Merged
merged 6 commits into from
Mar 21, 2025

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 18, 2025

This shaves another ~600ms on builds

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.27

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.33

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.26

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.29

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.25

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.18

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.18

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.15

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.32

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:06.23

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Mar 18, 2025
Copy link
Contributor

Thanks for your PR, @javiercn.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@javiercn javiercn force-pushed the javiercn/define-static-web-assets-incrementalism-main branch from c08b2e7 to fd9b5f8 Compare March 19, 2025 09:02
@javiercn javiercn requested a review from MackinnonBuck March 19, 2025 17:41
@javiercn javiercn marked this pull request as ready for review March 19, 2025 17:41
@Copilot Copilot bot review requested due to automatic review settings March 19, 2025 17:41
@javiercn javiercn requested review from a team as code owners March 19, 2025 17:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@javiercn javiercn force-pushed the javiercn/define-static-web-assets-incrementalism-main branch from fd9b5f8 to afbff6e Compare March 19, 2025 19:38
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think I have too many comments right now for me to approve, but I'm not anticipating many changes will need to be made. Most comments are seeking clarification.

@javiercn javiercn force-pushed the javiercn/define-static-web-assets-incrementalism-main branch from afbff6e to 63f2610 Compare March 20, 2025 16:10
@javiercn javiercn changed the base branch from main to javiercn/put-file-length-and-lastwrite-on-assets March 20, 2025 16:10
Base automatically changed from javiercn/put-file-length-and-lastwrite-on-assets to main March 20, 2025 19:08
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@javiercn javiercn force-pushed the javiercn/define-static-web-assets-incrementalism-main branch from a8dab71 to 08f002b Compare March 21, 2025 12:32
@javiercn javiercn merged commit 7bf5e9f into main Mar 21, 2025
39 checks passed
@javiercn javiercn deleted the javiercn/define-static-web-assets-incrementalism-main branch March 21, 2025 15:45
javiercn added a commit that referenced this pull request Mar 26, 2025
* Makes the task incremental and retrieves the results from a cache to avoid hitting disk to compute integrity and fingerprint on incremental builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants