Create a single copy of stub templates #114462
Open
+900
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
We can classify them based on binary format main...am11:runtime:binfmt and use: |
commit 40f2a6ac4c7393294d794f55aa9206f8eb815b5c Author: David Wrighton <[email protected]> Date: Tue Apr 1 15:16:13 2025 -0700 Build out ExecutableAllocator api for template mapping commit dd22e4213563461948e702f035c0558784c3f767 Author: David Wrighton <[email protected]> Date: Tue Apr 1 13:07:42 2025 -0700 X64 template code gen is correct commit 89fb8b6 Author: David Wrighton <[email protected]> Date: Mon Mar 31 14:00:23 2025 -0700 Add support for Amd64 thunk pages
…oreclr template in ways that are unsafe.
davidwrighton
force-pushed
the
thunks_from_image
branch
from
9d37418 to
53b3ce9
Compare
davidwrighton
changed the title
There was a problem hiding this comment.
Copilot reviewed 12 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (3)
- src/coreclr/clrdefinitions.cmake: Language not supported
- src/coreclr/vm/amd64/thunktemplates.S: Language not supported
- src/coreclr/vm/arm64/thunktemplates.S: Language not supported
Comments suppressed due to low confidence (2)
src/coreclr/vm/precode.cpp:527
- [nitpick] Consider replacing the magic constant 0x4000 with a named constant (e.g. kExpectedTemplatePageSize) to improve code clarity and maintainability.
if (StubPrecodeCodeTemplate != NULL && pageSize != 0x4000)
src/coreclr/vm/precode.cpp:674
- [nitpick] Consider replacing the magic constant 0x4000 with a named constant to enhance clarity and maintainability in the template usage check.
if (FixupPrecodeCodeTemplate != NULL && pageSize != 0x4000)
filipnavara
reviewed
Apr 16, 2025
There was a problem hiding this comment.
FWIW I checked the Apple specific code paths and they look reasonable.
I skimmed over the Linux parts too; they are similar in principle to the code used in NativeAOT before the switch to vm_remap. I didn't review them in detail though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating stub templates by running the code page generation function for each stub code region that is generated, map a single file into memory in multiple locations instead. This logic is architected so that it can fall back to the previous model of using the double mapping logic to generate the stubs.
We implement 3 schemes for finding the to use as mapping data.
dladdranddl_iterate_phdrfunctionality to find the file name of the coreclr binary and the section that contains it, and then we can use mmap to map from the file directly into memory. This mode is disabled by default as it doesn't support all scenarios, but it does allow for testing of the majority of the logic used on Apple platforms on a Linux machine.