Set Range header correctly in AddRange #113720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the behavior of the Range header in HttpWebRequest by correctly concatenating multiple range values rather than resetting the header. It also introduces new tests to verify correct behavior when adding single and multiple ranges.
- Fix the Range header concatenation logic in AddRange.
- Add tests to verify multiple range additions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs | Adds test cases for Range header handling when multiple ranges are added. |
| src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs | Modifies AddRange method to correctly append new range values. |
Comments suppressed due to low confidence (1)
src/libraries/System.Net/HttpWebRequest.cs:1546
- Changing from 'curRange = string.Empty;' to 'curRange += ",";' correctly preserves the existing header value when adding a second range. Confirm that this change handles all cases of Range header formatting as expected.
curRange += ",";
This was referenced Mar 20, 2025
|
/ba-g failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113690.
New tests verify the behavior that was observed under .NET Framework 4.7.2.