Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpStress] [SslStress] Run stress tests nightly against staging branches #113432

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

antonfirsov
Copy link
Member

This PR is the first step to address #113372:

  • always: true should ensure that the nightly run will happen even if there were no recent commits
  • The runs should happen against staging branches to make sure changes impact stress runs early

The PR should be backported to 8.0 and 9.0 staging branches to take effect.

Contributes to #113372

@Copilot Copilot bot review requested due to automatic review settings March 12, 2025 18:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the nightly stress test pipelines to ensure they always run and to include staging branches.

  • Added "always: true" to force nightly runs irrespective of recent commits.
  • Included "release/*-staging" branch pattern in both SSL and HTTP stress test pipelines.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/libraries/stress/ssl.yml Added "always: true" and new branch inclusion for staging branches.
eng/pipelines/libraries/stress/http.yml Added "always: true" and new branch inclusion for staging branches.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-ssl

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov changed the title run stress tests nightly against staging branches [HttpStress] [SslStress] Run stress tests nightly against staging branches Mar 12, 2025
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope globbing works after this is merged. 🤞

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antonfirsov antonfirsov merged commit 9c9178f into dotnet:main Mar 13, 2025
86 checks passed
@antonfirsov
Copy link
Member Author

/backport to release/9.0-staging

Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13839087501

@antonfirsov
Copy link
Member Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/13839091208

Copy link
Contributor

@antonfirsov backporting to "release/8.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: run stress tests nightly against staging branches
Using index info to reconstruct a base tree...
M	eng/pipelines/libraries/stress/http.yml
M	eng/pipelines/libraries/stress/ssl.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/ssl.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/ssl.yml
Auto-merging eng/pipelines/libraries/stress/http.yml
CONFLICT (content): Merge conflict in eng/pipelines/libraries/stress/http.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 run stress tests nightly against staging branches
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

antonfirsov added a commit that referenced this pull request Mar 13, 2025
antonfirsov pushed a commit that referenced this pull request Mar 14, 2025
Backport of #113432 to release/9.0-staging

Contributes to #113372.
antonfirsov added a commit that referenced this pull request Mar 14, 2025
Backport of #113432 to release/8.0-staging

Contributes to #113372.
hoyosjs added a commit that referenced this pull request Mar 15, 2025
* backport #113432 (#113479)

Backport of #113432 to release/8.0-staging

Contributes to #113372.

* Update dependencies from https://github.com/dotnet/arcade build 20250314.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.25114.5 -> To Version 8.0.0-beta.25164.5

* Update wasm test SDK

---------

Co-authored-by: Anton Firszov <[email protected]>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: vseanreesermsft <[email protected]>
Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants