-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] [QUIC] Update MsQuic library version #113206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tagging subscribers to this area: @dotnet/ncl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we need to update our dependencies to latest secure version.
The tests ran and passed on Windows supporting MsQuic (i.e. TLS 1.3), e.g.: https://helixr1107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-runtime-refs-pull-113206-merge-fd794bf5bdf8412c9b/System.Net.Quic.Functional.Tests/1/console.59eab2a3.log?helixlogtype=result
Kusto Query used:
|
Approved over email. |
/ba-g infrastructure failure dotnet/dnceng#5144 |
1f87c0a
into
dotnet:release/8.0-staging
Backport of #113159 from main (10.0) to release/8.0-staging
Contributes to #113136
Customer Impact
Security in-depth change in msquic library - found internally.
We are updating just msquic dependency to 2.4.8 (we have reship msquic binaries on Windows -- on Linux we rely on external package published by msquic team directly). No unique changes to .NET code.
Note: We have done similar update in 2024/3 - see commit 1207c32.
Regression
No
Testing
CI run - System.Net.Quic tests ran and passed, see #113206 (comment)
Risk
Low. Update of msquic library that is backward compatible (msquic team guaratnees it).
Also, customers on Linux get this version automatically with updates from their package managers.