Unicode 16.0 Support #111469
Merged
Unicode 16.0 Support #111469
+1,320
−1,222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
|
@GrabYourPitchforks @stephentoub @jkotas @matouskozak could you please help review this change? Thanks! CC @ericstj |
jkotas
approved these changes
Jan 15, 2025
stephentoub
reviewed
Jan 15, 2025
| @@ -204,14 +204,14 @@ private static void PrintValueArray<T>(string tableName, Dictionary<T, byte> d, | |||
|
|
|||
| private static void PrintByteArray(string tableName, StreamWriter file, byte[] str) | |||
| { | |||
| file.Write("\n private static ReadOnlySpan<byte> " + tableName + " => new byte[" + str.Length + "]\n {\n"); | |||
| file.Write("\n private static ReadOnlySpan<byte> " + tableName + " => // " + str.Length + "\n [\n"); | |||
There was a problem hiding this comment.
The commented length is just for readability / debuggability?
There was a problem hiding this comment.
Yes, it gives some idea about the data size too.
stephentoub
approved these changes
Jan 15, 2025
This was referenced Jan 16, 2025
Open
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-ioslike,runtime-ioslikesimulator,runtime-maccatalyst |
|
/azp run runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.