Microsoft.Extensions.Configuration support for Cosmos Clustering Provider #9204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
Is this ready for review? |
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
ReubenBond
approved these changes
Feb 6, 2025
|
@ReubenBond I believe it is, however I would want to run the pipelines again to ensure there aren't any hidden issues. |
Added a `using` directive for `System.Runtime.CompilerServices` and
an assembly attribute `[assembly: InternalsVisibleTo("Tester.AzureUtils")]`
to make internal types visible to the `Tester.AzureUtils` assembly.
Introduce CosmosClusteringProviderBuilder class implementing IProviderBuilder<ISiloBuilder> and IProviderBuilder<IClientBuilder> interfaces. Register the class as a provider for both "Silo" and "Client" roles. Implement Configure methods to set up Cosmos DB clustering options and client configuration. Import necessary namespaces to support the new functionality. This adds support for using the Cosmos DB Clustering Provider from Orleans IConfiguration setup.
ReubenBond
force-pushed
the
feature/cosmos-cluster-iconfiguration
branch
from
bf98daf to
ff3874c
Compare
|
@OmnipotentOwl I rebased and am re-running workflows. Ideally, we should update the tests to use this new configuration mechanism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
New feature: Introduce support for Cosmos DB clustering provider for Orleans via Microsoft.Extensions.Configuration.
PR Summary
This pull request supports the Cosmos DB clustering provider for Orleans to be configured via Microsoft.Extensions.Configuration, enabling clustering configurations for both Silo and Client roles.
CosmosClusteringProviderBuilderclass and registered it as a provider.CosmosClusteringOptionsand a validator class.[assembly: InternalsVisibleTo("Tester.AzureUtils")]attribute.Microsoft Reviewers: Open in CodeFlow