Use UpDownCounter for grain and system target counts #8781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UpDownCounter and Counter have the same implementation but they are interpreted differently by the .Net OTel SDK. UpDownCounter supports reporting negative values and is suitable to keep track of the number of active grain per type. The metric will be exported by the OTel SDK as a cumulative value instead of a delta for Counter.
ReubenBond
approved these changes
Dec 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8753
UpDownCounter and Counter have the same implementation but they are interpreted differently by the .Net OTel SDK. UpDownCounter supports reporting negative values and is suitable to keep track of the number of active grains per type. The metric will be exported by the OTel SDK as a cumulative value instead of a delta for Counter.
Microsoft Reviewers: Open in CodeFlow