Skip to content

[JavaCallableWrappers] Remove was_scanned from XmlImporter/XmlExporter. #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

[JavaCallableWrappers] Remove was_scanned from XmlImporter/XmlExporter. #1325

merged 1 commit into from
Apr 8, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 18, 2025 •
edited
Loading

Context: dotnet/android#9930

Make a few tweaks to JCW serialization for dotnet/android#9930:

  • We no longer need was_scanned, we now write a zero byte file to indicate a file was not scanned.
  • Add an overload to import from an XElement, as the full .jlo.xml file now contains additional non-JCW data.

@jpobst jpobst mentioned this pull request Apr 1, 2025
Merged
@jpobst jpobst marked this pull request as ready for review April 1, 2025 21:40
@jpobst jpobst requested a review from jonpryor April 1, 2025 21:40
@jonpryor jonpryor merged commit 8221b7d into main Apr 8, 2025
2 checks passed
@jonpryor jonpryor deleted the dev/jpobst/acw-map branch April 8, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpobst @jonpryor