Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize project settings to opt-out from 'unused bindings' detection across the repo #18431

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Standardize project settings to opt-out from 'unused bindings' detection across the repo #18431

wants to merge 18 commits into from

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Mar 31, 2025 •
edited
Loading

Use <TolerateUnusedBindings>true</TolerateUnusedBindings> as an override of the default, especially in test projects.
Keep erroring on unused bindings as the default option for all projects.

Avoid repetitive blocks like

    <NoWarn>$(NoWarn);1182</NoWarn> 
    <OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro marked this pull request as ready for review April 11, 2025 10:57
@T-Gro T-Gro requested a review from a team as a code owner April 11, 2025 10:57
@T-Gro T-Gro enabled auto-merge (squash) April 11, 2025 10:57
psfinaki
psfinaki approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T-Gro @psfinaki