Fixed lazy loading thread safety #35529
Conversation
- Added sync for lazy loading Fixes #35528
|
@dotnet-policy-service agree |
Added tests for lazy loading thread safety
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
@henriquewr Could you explain what the issue in the original code was? It seems that it made some incorrect assumption, but I don't see what it was exactly |
|
Oh, I see. While it prevented a second thread from loading it didn't make it wait for the first thread to finish. |
|
@AndriySvyryd Exacly that what i was going to say |
fixed async lazy loading
|
|
||
| if (exists) | ||
| { | ||
| if (isLoadingValue.Depth.Value == 1) |
There was a problem hiding this comment.
This is an interesting optimization. It definitely warrants a comment on how it works as the next person to read this code will be very confused.
@roji @cincuranet What's your opinion of this usage of AsyncLocal?
|
Thanks for your contribution! |
|
You're welcome, I'm happy to contribute |
Added sync for lazy loading
Fixes #35528