Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for primitive collections to the compiled model #35370

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

AndriySvyryd
Copy link
Member

Fixes #35047

@AndriySvyryd AndriySvyryd requested a review from a team as a code owner December 22, 2024 05:53
@AndriySvyryd AndriySvyryd requested a review from Copilot December 22, 2024 05:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 56 out of 71 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/Basic_cosmos_model/DataEntityType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/No_NativeAOT/OwnedType0EntityType.cs: Evaluated as low risk
  • src/EFCore/Metadata/RuntimeElementType.cs: Evaluated as low risk
  • src/EFCore/Design/Internal/CSharpRuntimeAnnotationCodeGenerator.cs: Evaluated as low risk
  • src/EFCore/Design/Internal/ICSharpRuntimeAnnotationCodeGenerator.cs: Evaluated as low risk
  • src/EFCore/Metadata/Conventions/RuntimeModelConvention.cs: Evaluated as low risk
  • src/EFCore/Metadata/IElementType.cs: Evaluated as low risk
  • src/EFCore/Metadata/RuntimeProperty.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/No_NativeAOT/ManyTypesEntityType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/ComplexTypes/PrincipalBaseEntityType.cs: Evaluated as low risk
  • src/EFCore/Metadata/Internal/ElementType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/BigModel/ManyTypesEntityType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/BigModel/OwnedType0EntityType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/BigModel/OwnedTypeEntityType.cs: Evaluated as low risk
  • test/EFCore.Cosmos.FunctionalTests/Scaffolding/Baselines/BigModel/PrincipalBaseEntityType.cs: Evaluated as low risk
Comments suppressed due to low confidence (3)

src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs:1433

  • [nitpick] The method name 'CreateValueComparerType' is ambiguous. Consider renaming it to 'GenerateValueComparerInstance'.
private string CreateValueComparerType(Type valueComparerType, Type clrType, CSharpRuntimeAnnotationCodeGeneratorParameters parameters)

src/EFCore.Design/Scaffolding/Internal/CSharpRuntimeModelCodeGenerator.cs:1306

  • Ensure that the new behavior introduced by the 'Create' method for 'IElementType' is covered by tests.
var elementType = property.GetElementType();

src/EFCore.Relational/Storage/RelationalTypeMapping.cs:574

  • The removal of this debug assertion could lead to unintended behavior if a null value is passed to a non-nullable input parameter.
Check.DebugAssert(nullable.Value || !direction.HasFlag(ParameterDirection.Input) || value != null, "Null value in a non-nullable input parameter");
@AndriySvyryd AndriySvyryd disabled auto-merge January 31, 2025 04:43
@AndriySvyryd AndriySvyryd merged commit 82e9c23 into main Jan 31, 2025
5 of 7 checks passed
@AndriySvyryd AndriySvyryd deleted the Issue35047 branch January 31, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsPrimitiveCollection metadata is incorrect when using the compiled model
2 participants