Change deployment samples to be ready-to-deploy files #7926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jander-msft
changed the title
kkeirstead
reviewed
Feb 7, 2025
| memory: 512Mi | ||
| - name: monitor | ||
| image: mcr.microsoft.com/dotnet/monitor:8 | ||
| # DO NOT use the --no-auth argument for deployments in production; this argument is used for demonstration |
There was a problem hiding this comment.
Just a bit of a quirk with some of our comments in a couple of places - if someone references this yaml in isolation, these don't mean much and don't tell you where to get clarification.
kkeirstead
reviewed
Feb 7, 2025
| memory: 512M | ||
|
|
||
| monitor: | ||
| image: mcr.microsoft.com/dotnet/monitor:8 |
There was a problem hiding this comment.
Any reason we're using 8 for these examples instead of 9?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change allows users to easily run the sample deployments without having to copy/paste them first; just checkout the repository and run the deployment. For Kubernetes, I've only created a single sample based on .NET Monitor 8 since the prior versions are out of support and the sample applies to .NET Monitor 8 and forward. Additionally, I changed the app image to use the chiseled variant so that the users of the app and the .NET Monitor container match.
Release Notes Entry