Explain semantics of multiple calls to CancellationTokenSource.Cancel
#11105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also copy a line about LIFO semantics from one of the overloads, to unify the docs for each function.
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Smaug123
commented
Mar 18, 2025
|
Learn Build status updates of commit 5a2b566: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
gewarren
added
area-System.Threading
and removed
needs-area-label
gewarren
reviewed
Mar 25, 2025
|
Some scope creep, but I've gone over every use of the word "will" in the file and replaced it with a present tense unless it's describing asynchrony or future actions. |
|
Learn Build status updates of commit 8094c7a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also copy a line about LIFO semantics from one of the overloads, to unify the docs for each function.
Summary
Earlier today, I needed to perform several experiments to discover the semantics of
CancellationTokenSource.Cancel, because they are undocumented.I don't know the semantics of
CancelAsync, so I haven't documented them.