-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breaking change documentation for SYSLIB0061 #45565
Conversation
Document the obsoletion of the `System.Linq.Queryable.MaxBy` and `System.Linq.Queryable.MinBy` methods accepting an `IComparer<TSource>`. Also fixed the rendering of the table in obsoletions-overview.md
First stab at doing this @CamSoper @teo-tsirpanis @eiriktsarpalis Please let me know if I missed anything :) |
I guess I need to figure out the |
Also, those preview links are asking me to login... I suspect that's not for public consumption... I presume that I lack rights on https://review.learn.microsoft.com |
Correct, if you don't have a microsoft.com address, it won't let you view the staging site. I fixed your xrefs. As soon as it builds I'll approve. LMK if you're ready to merge. |
@IDisposable That last xref I overlooked has been fixed now, too. I have an internal tool that makes it easier to look them up and get the correct syntax. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, @IDisposable! Just to make sure, do these look like the right overloads? If you say we're good, I'll
Yep, those are the two. The tell is |
The code change has been merged dotnet/runtime#113944 |
Fixed typo |
Summary
Document the obsoletion of the
System.Linq.Queryable.MaxBy<>
andSystem.Linq.Queryable.MinBy<>
methods accepting anIComparer<TSource> comparer
.Also fixed the rendering of the table in obsoletions-overview.md
Fixes #45535
Internal previews