-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): Correct default rollForward policy in global.json documentation #44996
base: main
Are you sure you want to change the base?
Conversation
@JL03-Yue are you able to verify this change? |
@adegeo Are you familiar with this at all? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't tell if this is a bot or not...
What does this have to do with this PR?
Fixes Visual Studio Code branding (if an issue exists in the repo).
The linked PR that's referenced here indicates in the discussion that the default was actually not changed, though the initial comment indicates it would be.
References Implement roll-forward policies for .NET Core SDK resolution. core-setup#6953.
This is the same link as above, there aren't tracing logs? So I don't know what this is referencing.
However, based on actual SDK behavior and tracing logs (see core-setup#6953, the default policy is actually patch, not latestPatch.
📜 Description
This PR updates the global-json.md documentation to correctly reflect the default
rollForward
behavior in the .NET SDK.🔍 Issue
The documentation previously stated:
However, based on actual SDK behavior and tracing logs (see dotnet/core-setup#6953), the default policy is actually
patch
, notlatestPatch
.🛠 Fix
global-json.md
to specifypatch
as the default rollForward policy.📎 Related Issues
📸 Verification
✅ The demo provided in the issue confirms that
patch
is the default policy.✅ Tracing logs explicitly state
rollForward = 'patch'
.📂 Files Changed
docs/core/tools/global-json.md
🔗 Additional Context
For backwards compatibility, the SDK defaults to
patch
whenrollForward
is not specified inglobal.json
. This update ensures that the documentation accurately reflects this behavior.Internal previews