Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnPrepareResponseAsync #45062

Merged
merged 17 commits into from
Nov 23, 2022
Merged

Add OnPrepareResponseAsync #45062

merged 17 commits into from
Nov 23, 2022
+160 −9

Conversation

stefannikolei
Copy link
Contributor

@stefannikolei stefannikolei commented Nov 13, 2022 •
edited
Loading

Add OnPrepareResponseAsync to StaticFileMiddleware #44932

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Nov 13, 2022
@ghost
Copy link

ghost commented Nov 13, 2022

Thanks for your PR, @stefannikolei. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

stefannikolei and others added 3 commits November 13, 2022 13:54
@stefannikolei @JamesNK
Update src/Middleware/StaticFiles/src/StaticFileOptions.cs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f079b38 
Co-authored-by: James Newton-King <[email protected]>
@stefannikolei @JamesNK
Update src/Middleware/StaticFiles/src/StaticFileContext.cs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d49e444 
Co-authored-by: James Newton-King <[email protected]>
@stefannikolei @JamesNK
Update src/Middleware/StaticFiles/src/StaticFileOptions.cs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9f81edf 
Co-authored-by: James Newton-King <[email protected]>
@stefannikolei stefannikolei changed the title #44932 Add OnPrepareResponseAsync Add OnPrepareResponseAsync Nov 13, 2022
Tratcher
Tratcher reviewed Nov 15, 2022
View reviewed changes
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for each callback, and their ordering. This should be a good example:

aspnetcore/src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddlewareTests.cs

Line 175 in d0f60f2

private async Task FoundFile_Served(string baseUrl, string baseDir, string requestUrl)

stefannikolei and others added 3 commits November 15, 2022 10:40
@stefannikolei @Tratcher
Update src/Middleware/StaticFiles/src/StaticFileOptions.cs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dc48d07 
Co-authored-by: Chris Ross <[email protected]>
@stefannikolei
Reorder the log
a28fb73
@stefannikolei
Add Tests
62e9711
stefannikolei and others added 3 commits November 21, 2022 21:13
@stefannikolei @Tratcher
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c0970bb 
…Tests.cs

Co-authored-by: Chris Ross <[email protected]>
@stefannikolei @Tratcher
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5fadece 
…Tests.cs

Co-authored-by: Chris Ross <[email protected]>
@stefannikolei
Use booleans to check invocation order
67a67b4
@JamesNK
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
925408a 
…Tests.cs
@Tratcher
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e5dbbd9 
…Tests.cs
stefannikolei and others added 2 commits November 22, 2022 20:47
@stefannikolei @Tratcher
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
fc6c5fd 
…Tests.cs

Co-authored-by: Chris Ross <[email protected]>
@stefannikolei @Tratcher
Update src/Middleware/StaticFiles/test/UnitTests/StaticFileMiddleware…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c93ed27 
…Tests.cs

Co-authored-by: Chris Ross <[email protected]>
@Tratcher Tratcher merged commit ceffcc9 into dotnet:main Nov 23, 2022
@ghost ghost added this to the 8.0-preview1 milestone Nov 23, 2022
@Tratcher
Copy link
Member

Thanks

@amcasey amcasey added area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK

@Tratcher Tratcher

@campersau campersau

@BrennanConroy BrennanConroy

Assignees

@Tratcher Tratcher

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stefannikolei @Tratcher @JamesNK @campersau @adityamandaleeka @amcasey