Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kafbat/kafkaui #7830

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Use Kafbat/kafkaui #7830

merged 3 commits into from
Mar 3, 2025

Conversation

stefannikolei
Copy link
Contributor

Description

The KafkaUi from provectus is not really maintained anymore. The one over at https://github.com/kafbat/kafka-ui is a fork of it and is actively maintained.

This PR exchanges the image. The config is the same for both images.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 28, 2025
@davidfowl
Copy link
Member

cc @g7ed6e

@mitchdenny
Copy link
Member

This looks fine to me but would definitely like @g7ed6e to weigh in.

@g7ed6e
Copy link
Contributor

g7ed6e commented Mar 3, 2025

LGTM. Thanks @stefannikolei !

@stefannikolei
Copy link
Contributor Author

I now also created a pr for the required doc changes --> dotnet/docs-aspire#2712

@mitchdenny mitchdenny merged commit f7736dd into dotnet:main Mar 3, 2025
71 checks passed
@mitchdenny
Copy link
Member

Thanks @stefannikolei and @g7ed6e

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants