Resolve DistributedApplicationResourceBuilder<ResourceWithConnectionStringSurrogate> correctly in args evaluation

[adamint]

Description

ResourceWithConnectionStringSurrogate is wrapped in its builder when we are processing args, and so we should evaluate the underlying resource.

The right fix might be to do that for all DistributedApplicationResourceBuilder, but I'm not confident that would be correct. I can't find other cases where a builder is passed instead of the resource, does anyone else know? @mitchdenny for thoughts? keeping this as a draft during discussion

Fixes #7662 (comment)

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

[mitchdenny]

So I had a look at .NET Aspire 9.0 and this problem still existed there so this isn't a regression. But it is a gap that we need to fill. I think your solution is fine, but it needs some test cases to make sure that we don't accidentally regress this behavior.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

[mitchdenny]

LGTM. Thanks for jumping on this @adamint

[mitchdenny]

/backport to release/9.1

[github-actions]

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13447964177