Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Seq #6032

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add tests for Seq #6032

wants to merge 4 commits into from

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Sep 30, 2024

Description

Add tests for Seq resource.

I need to figure out how to send events to seq to add functional tests. (Seq.Api package doesn't support sending raw events)

Related #4741

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 30, 2024
@danmoseley
Copy link
Member

I need to figure out how to send events to seq to add functional tests. (Seq.Api package doesn't support sending raw events)

@Alirexaa did you figure this out? if not @sebastienros can likely help.

@danmoseley danmoseley added the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 2, 2025
@davidfowl
Copy link
Member

I don't think this is a @sebastienros question, more a @nblumhardt one 😄

@davidfowl
Copy link
Member

@nblumhardt, @liammclennan would you be willing to take over the seq packages for aspire?

@nblumhardt
Copy link

Hi @Alirexaa! Aside from pointing a logging library or OpenTelemetry SDK at it, you can add events to Seq by POSTing newline-delimited JSON to the /ingest/clef endpoint; the format looks like this:

{"@t":"2025-02-03T12:34:56.789Z","@m":"Hello!"}

The complete field reference is here. Hope this helps!

@nblumhardt
Copy link

@davidfowl Is there a change in direction around where the Aspire component library is being developed? (I haven't been keeping up to date 😅). We'd need to get an idea of what it entails, but in principle, happy to help if we can 👍

@davidfowl
Copy link
Member

We've been working with various vendors to move integrations (where it makes sense).

@Alirexaa
Copy link
Contributor Author

Alirexaa commented Feb 7, 2025

@Alirexaa did you figure this out?

@danmoseley, PR is ready for review.

@Alirexaa Alirexaa marked this pull request as ready for review February 7, 2025 17:41
@dotnet-policy-service dotnet-policy-service bot removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Feb 7, 2025
@nblumhardt
Copy link

@davidfowl thanks for your reply; I think it might be the easiest way to keep the package up-to-date and moving forward 👍

There's one other open PR to the Seq component, #6878, which it'd be great to get some guidance on. Perhaps once that's merged or bounced, we open a ticket and figure out the best way to coordinate a transition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants