Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Enable eventhubs emulator dependent tests #5713

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

radical
Copy link
Member

@radical radical commented Sep 14, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@radical
Copy link
Member Author

radical commented Sep 14, 2024

Trying to enable the tests and see where this gets.

@davidfowl
Copy link
Member

davidfowl commented Sep 14, 2024

functions tests will break because we have service bus under the same ifdef.

https://github.com/dotnet/aspire/pull/5593/files

cc @captainsafia

@captainsafia
Copy link
Member

functions tests will break because we have service bus under the same ifdef.

https://github.com/dotnet/aspire/pull/5593/files

cc @captainsafia

I figured taking a shortcut and not defining a new property would eventually bite us when we figured out EventHubs emulation. Glad that happened so soon. We can rename the existing property/#define constant and shuffle the code around and be good. 👍🏽

@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure and removed area-components labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages azure Issues associated specifically with scenarios tied to using Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants