Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] SlimTestProgramTests: Wait for services to start #5668

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

radical
Copy link
Member

@radical radical commented Sep 10, 2024

The HttpClient used in the tests don't have resilience, so if
TestProgram takes longer to startup, then http requests to the
services can fail.

Instead, explicitly wait for Application started messages on the
services before sending a request.

Fixes #5637

Microsoft Reviewers: Open in CodeFlow

The HttpClient used in the tests don't have resilience, so if
`TestProgram` takes longer to startup, then http requests to the
services can fail.

Instead, explicitly wait for `Application started` messages on the
services before sending a request.

Fixes dotnet#5637
@radical radical requested a review from mitchdenny as a code owner September 10, 2024 05:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Sep 10, 2024
@radical radical requested a review from joperezr September 10, 2024 22:52
@eerhardt eerhardt merged commit 6d23f88 into dotnet:main Sep 11, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication testing ☑️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some flaky Aspire.Hosting.Tests.SlimTestProgramTests tests
3 participants