Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Enable playwright tests on linux (#4838) #5066

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[tests] Enable playwright tests on linux (#4838) #5066

wants to merge 2 commits into from

Conversation

radical
Copy link
Member

@radical radical commented Jul 24, 2024 •
edited
Loading

Playwright dependencies have been installed on the helix image.

Issue: #4623 .
Fixed by resolution of dotnet/dnceng#3122 .

Microsoft Reviewers: Open in CodeFlow

@radical
[tests] Enable playwright tests on linux (dotnet#4838)
86dab6f 
Playwright dependencies have been installed on the helix image.

Issue: dotnet#4623
@radical radical requested a review from eerhardt as a code owner July 24, 2024 23:18
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 24, 2024
@radical radical requested a review from joperezr July 24, 2024 23:19
@radical radical added area-engineering-systems infrastructure helix infra engineering repo stuff testing ☑️ and removed area-codeflow for labeling automated codeflow. intentionally a different color! labels Jul 24, 2024
@build-analysis build-analysis bot mentioned this pull request Jul 25, 2024
Open
@radical
Copy link
Member Author

radical commented Jul 25, 2024

Looks like we need to wait for the new VMs to roll out.

joperezr
joperezr approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, of course assuming that the dependencies we need are now installed on the machines as expected.

@radical
Copy link
Member Author

radical commented Aug 9, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 9, 2024

  • Next: confirm that the packages are actually installed on the agent. If they are, then are we missing something else which is causing the tests to complain about missing dependencies?

@radical radical added the blocked label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joperezr joperezr joperezr approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

Assignees
No one assigned
Labels
area-engineering-systems infrastructure helix infra engineering repo stuff blocked testing ☑️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @joperezr