Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeflow documentation in PR description #4565

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamzip
Copy link
Contributor

@adamzip adamzip commented Mar 14, 2025

@adamzip adamzip requested review from Copilot, premun and dkurepa March 14, 2025 16:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds an extra parameter (isForwardFlow) to several methods in the pull request builder and updater classes to enable differential behavior in codeflow updates, along with corresponding updates to tests and method calls.

  • Updated method signatures in PullRequestBuilder to include the new isForwardFlow parameter.
  • Adjusted test cases in PullRequestBuilderTests to supply the new parameter and updated expected description formatting.
  • Modified PullRequestUpdater methods to pass through the isForwardFlow parameter to maintain consistent behavior.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs Added isForwardFlow parameter in method signatures and updated PR description formatting with a new markdown note.
test/ProductConstructionService.DependencyFlow.Tests/PullRequestBuilderTests.cs Updated test calls and expected outputs to include isForwardFlow parameter for codeflow descriptions.
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestUpdater.cs Updated method calls to pass the isForwardFlow parameter in PR update/creation functions.
Comments suppressed due to low confidence (1)

src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestBuilder.cs:257

  • The inserted markdown note block in the PR description contains extra leading whitespace that may affect the rendered formatting. Consider normalizing the indentation to ensure consistent display.
                > [!NOTE]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant