Add flat flow test functionality to the ReproTool #4559
Conversation
|
we can check this code in, or just keep it on my branch, since we probably won't need it after switching to flat flow in a month |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds multiple new test operations to support flat and full flow tests in the ReproTool and refactors the options and service registration. Key changes include the introduction of FullBackflowTestOperation, FlatFlowTestOperation, and ReproOperation along with updates to the Program entry-point and shared library helper methods.
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/ProductConstructionService.ReproTool/Options/FullBackflowTestOptions.cs | New options class for full backflow tests with duplicate license header comments. |
| tools/ProductConstructionService.ReproTool/Operations/FullBackflowTestOperation.cs | New operation implementing the full backflow test functionality. |
| tools/ProductConstructionService.ReproTool/Options/FlatFlowTestOptions.cs | New options class for flat flow tests. |
| tools/ProductConstructionService.ReproTool/Operations/ReproOperation.cs | Updated operation for reproducing code flow subscriptions. |
| tools/ProductConstructionService.ReproTool/Operations/FlatFlowTestOperation.cs | New operation for flat flow test execution. |
| tools/ProductConstructionService.ReproTool/Operations/Operation.cs | Base class for common helper methods and constants shared across operations. |
| tools/ProductConstructionService.ReproTool/Program.cs | Updated program to parse multiple verbs and use GetOperation to run the selected test. |
| tools/ProductConstructionService.ReproTool/Options/ReproOptions.cs | Updated options for the repro operation with minor header duplication. |
| tools/ProductConstructionService.ReproTool/DarcProcessManager.cs | Adjustments in subscription creation and command execution parameters. |
| tools/Tools.Common/Constants.cs, tools/FlatFlowMigrationCli/* | Namespace and minor reference updates to support common functionality. |
| tools/ProductConstructionService.ReproTool/ReproTool.cs | Removal of the legacy ReproTool class in favor of the new operation-based design. |
tools/ProductConstructionService.ReproTool/Options/FullBackflowTestOptions.cs
Outdated
Show resolved
Hide resolved
| @@ -1,18 +1,21 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| // Licensed to the .NET Foundation under one or more agreements. | |||
There was a problem hiding this comment.
Duplicate license header found. Remove the redundant header lines to streamline the file header.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
…wTestOptions.cs Co-authored-by: Copilot <[email protected]>
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
There was a problem hiding this comment.
| // Licensed to the .NET Foundation under one or more agreements. | |
| // The .NET Foundation licenses this file to you under the MIT license. |
| [Option("github-token", HelpText = "GitHub token", Required = false)] | ||
| public string? GitHubToken { get; set; } |
There was a problem hiding this comment.
I'd kill this option and only allow it people to use user secrets or ENV variables
| [Option("target-branch", HelpText = "Target branch in all repos", Required = true)] | ||
| public required string TargetBranch { get; init; } |
There was a problem hiding this comment.
How does this work? Doesn't the branch differ per repo?
I think the branch you get from the dependency resolver should be the target branch.
| var vmrRepos = await vmrDependencyResolver.GetVmrRepositoriesAsync( | ||
| "https://github.com/dotnet/dotnet", | ||
| "https://github.com/dotnet/sdk", | ||
| "main"); |
There was a problem hiding this comment.
This should probably come from the Options.VmrBranch?
| "https://github.com/dotnet/sdk", | ||
| "main"); | ||
|
|
||
| vmrRepos = vmrRepos.Where(d => d.Mapping.Name == "runtime").ToList(); |
| var productRepoForkUri = $"{ProductRepoFormat}{vmrRepo.Mapping.Name}"; | ||
| if (vmrRepo.Mapping.Name == "nuget-client") | ||
| { | ||
| productRepoForkUri = $"{ProductRepoFormat}nuget.client"; | ||
| } |
There was a problem hiding this comment.
The URI is in vmrRepo.Channel.Repository
| protected const string VmrForkRepoName = "dotnet"; | ||
| protected const string VmrForkUri = $"https://github.com/{MaestroAuthTestOrgName}/{VmrForkRepoName}"; | ||
| protected const string ProductRepoFormat = $"https://github.com/{MaestroAuthTestOrgName}/"; | ||
| protected const long InstallationId = 289474; |
There was a problem hiding this comment.
Is this really needed? The first subscription you add should look it up correctly.
| var productRepoForkUri = $"{ProductRepoFormat}{vmrRepo.Mapping.Name}"; | ||
| if (vmrRepo.Mapping.Name == "nuget-client") | ||
| { | ||
| productRepoForkUri = $"{ProductRepoFormat}nuget.client"; | ||
| } |
| using ProductConstructionService.ReproTool.Operations; | ||
|
|
||
| namespace ProductConstructionService.ReproTool.Options; | ||
| [Verb("flat-flow-test", HelpText = "Test full flat flow in the maestro-auth-test org")] |
There was a problem hiding this comment.
Should this be forward flow test?
#4530