Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VBump SNI to v6.0.2 #3117

Merged
merged 1 commit into from
Jan 21, 2025
Merged

VBump SNI to v6.0.2 #3117

merged 1 commit into from
Jan 21, 2025

Conversation

benrr101
Copy link
Contributor

Description: Updating SNI to v6.0.2 to bring in fixes to targets file.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@benrr101 benrr101 requested a review from a team January 15, 2025 22:14
@benrr101
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (ebfbebb) to head (0bed3ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3117      +/-   ##
==========================================
+ Coverage   72.72%   72.76%   +0.04%     
==========================================
  Files         283      283              
  Lines       58996    58997       +1     
==========================================
+ Hits        42905    42930      +25     
+ Misses      16091    16067      -24     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.56% <ø> (+0.05%) ⬆️
netfx 71.24% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update release/6.0 branch too.

@benrr101
Copy link
Contributor Author

Please update release/6.0 branch too.

#3116

@benrr101 benrr101 merged commit 89f5dcb into main Jan 21, 2025
252 checks passed
@benrr101 benrr101 deleted the russellben/vbump-sni branch January 21, 2025 18:48
@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 22, 2025

@benrr101 @cheenamalhotra Using latest main I am not able to run Manual test in the Test Explorer in VS, and am concerned it might be related to this

Microsoft.Data.SqlClient.ManualTesting.Tests.ParametersTest.TestDateOnlyTVPDataTable_CommandSP
   Source: ParametersTest.cs line 399
   Duration: 522 ms

  Message: 
System.DllNotFoundException : Unable to load DLL 'Microsoft.Data.SqlClient.SNI.dll' or one of its dependencies: The specified module could not be found. (0x8007007E)

  Stack Trace: 
SniNativeMethods.UnmanagedIsTokenRestricted(IntPtr token, Boolean& isRestricted)
SniNativeMethods.SniIsTokenRestricted(IntPtr token, Boolean& isRestricted) line 61
SniNativeWrapper.UnmanagedIsTokenRestricted(IntPtr token, Boolean& isRestricted) line 141
Win32NativeMethods.IsTokenRestrictedWrapper(IntPtr token) line 598
DbConnectionPoolIdentity.GetCurrentNative() line 46
DbConnectionPoolIdentity.GetCurrent() line 31
DbConnectionPoolGroup.GetConnectionPool(DbConnectionFactory connectionFactory) line 170
DbConnectionFactory.GetConnectionPool(DbConnection owningObject, DbConnectionPoolGroup connectionPoolGroup) line 439
DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection) line 225
DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions) line 963
DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions) line 43
SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides) line 1970
SqlConnection.Open(SqlConnectionOverrides overrides) line 1413
SqlConnection.Open() line 1390
DataTestUtility.ResurrectConnection(SqlConnection sqlConnection, Int32 counter) line 637
DataTestUtility.DropStoredProcedure(SqlConnection sqlConnection, String spName) line 626
ParametersTest.TestDateOnlyTVPDataTable_CommandSP() line 441
RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@ErikEJ
Copy link
Contributor

ErikEJ commented Jan 22, 2025

If I add this to the test project, the test passes!

    <PackageReference Include="Microsoft.Data.SqlClient.SNI.runtime" Version="$(MicrosoftDataSqlClientSNIRuntimeVersion)" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants