feat: add responsive 404 error page with modern design and decorations #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erison7596
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
|
Hi @erison7596. I would like to know how this |
dostonnabotov
requested changes
Feb 6, 2025
| padding: 12px 24px; | ||
| background: #007dfe; | ||
| color: #ffffff; | ||
| font-family: "Rubik", sans-serif; |
There was a problem hiding this comment.
We recommend using our own declared fonts instead of new ones.
| font-family: "Rubik", sans-serif; | ||
| font-size: 18px; | ||
| font-weight: 400; | ||
| color: #555555; |
There was a problem hiding this comment.
As @psychlone77 suggested as well, using custom variables help match with both dark and light themes
| margin: 20px 0; | ||
| } | ||
|
|
||
| .notfound-description { |
There was a problem hiding this comment.
We use BEM naming convention for naming selectors. You can refer here for details: https://getbem.com/
Mathys-Gasnier
requested changes
Feb 7, 2025
| @@ -0,0 +1,25 @@ | |||
| import React from "react"; | |||
| import svg404 from "public/404.svg"; // Altere para o caminho correto da imagem 404 | |||
There was a problem hiding this comment.
Please make the comment in english
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots