Optimize the code for better speed #246
Open
+46
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimize the code for better speed. * **CategoryList Component**: Replace `useEffect` with `useMemo` to memoize fetched categories, reducing unnecessary re-renders. * **useKeyboardNavigation Hook**: Replace switch statement with a more optimized approach using a record of actions for handling keyboard events. * **useEscapeKey Hook**: Use a single event listener for better performance. * **useSnippets Hook**: Cache fetched data using `useMemo` to improve performance. * **CodePreview Component**: Replace `useEffect` with a more efficient method for handling theme changes using a mutation observer.
lawrencemillard
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
|
Hey, there. Thanks for the optimizations. We will be able to merge the PR once the search functionality is implemented on #159. Because it's a pretty big PR with a lot of changes. |
|
Please resolve conflicts and we will be able to review |
|
Hey there, @lawrencemillard. Search functionality (#159) is successfully implemented. Feel free to resolve the conflicts and we should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the code for better speed.
useEffectwithuseMemoto memoize fetched categories, reducing unnecessary re-renders.useMemoto improve performance.useEffectwith a more efficient method for handling theme changes using a mutation observer.