Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-13958 Improve job management #216

Closed
wants to merge 26 commits into from

Conversation

hiiamelliott
Copy link
Contributor

Link to JIRA

PS-13958

What issue does this pull request solve?

Extends the query functionality of jobs_list() to include as many of the options available in Domino's REST API as possible.

What is the solution?

Added additional arguments and set their default values to match those in the REST API.

Testing

Tested by listing previous jobs in a project. As the function explicitly sends the default API values, it uses all of the query parameters by default.

Pull Request Reminders

References (optional)

@hiiamelliott hiiamelliott requested a review from a team as a code owner March 7, 2025 18:31
@hiiamelliott hiiamelliott changed the title Hiiamelliott improve job management PS-13958 Improve job management Mar 11, 2025
Copy link
Contributor

@ddl-s-rodriguez ddl-s-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the changes done related to the versioning? (CHANGELOG.md, README.adoc, README.md and _version.py)?

We usually add those when we cut a new version together with other things that get merged as well

@ddl-s-rodriguez
Copy link
Contributor

Would you also mind updating your branch with the latest in master? So I can test if the dependencies bump keeps working in our CI. Thanks!

@hiiamelliott
Copy link
Contributor Author

Thanks @ddl-s-rodriguez, I tried to revert the changes and rebase, but the branch is in a mess now.
I'm going to abandon this PR and open a new one on a new branch, to keep the merge clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants