Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Db/dolt ci #8225

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Db/dolt ci #8225

wants to merge 25 commits into from

Conversation

coffeegoddd
Copy link
Contributor

@coffeegoddd coffeegoddd commented Aug 7, 2024 •
edited
Loading

Add Dolt system tables used for storing Continuous Integration configuration.

@coffeegoddd coffeegoddd requested a review from jycor August 7, 2024 21:01
jycor
jycor approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small changes

go/libraries/doltcore/sqle/dtables/ci_workflows.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/ci_workflows.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7c74d56 ok 5937457
version total_tests
7c74d56 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
02346e8 ok 5937457
version total_tests
02346e8 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple minor suggestions where I think you could trim down WorkflowsTable and make it a little simpler, but nothing major.

go/libraries/doltcore/sqle/dtables/ci_workflows.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/ci_workflows.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/ci_workflows.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7a86c74 ok 5937457
version total_tests
7a86c74 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
10c0db0 ok 5937457
version total_tests
10c0db0 5937457
correctness_percentage
100.0

@coffeegoddd coffeegoddd reopened this Aug 14, 2024
@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
10c0db0 ok 5937457
version total_tests
10c0db0 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e7018b7 ok 5937457
version total_tests
e7018b7 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8328e56 ok 5937457
version total_tests
8328e56 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6674209 ok 5937457
version total_tests
6674209 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6674209 ok 5937457
version total_tests
6674209 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
413088a ok 5937457
version total_tests
413088a 5937457
correctness_percentage
100.0

@coffeegoddd
/go/libraries/doltcore/{doltdb,schema,sqle}: add workflow events table
4714e71
@coffeegoddd
/libraries/doltcore/sqle: wip, trying to get foreign key added
069ed1f
@coffeegoddd
/go/libraries/doltcore/{doltdb,sqle}: wip, trying to add unresolved f…
7a1685c 
…oreign key
@coffeegoddd
/go/libraries/doltcore/sqle: wip, still trying to get foreign keys wo…
6e05086 
…rking
@coffeegoddd
/go/libraries/doltcore/sqle: wip, select and insert works, delete doe…
180c81d 
…s not, schema does not show foreign key
@coffeegoddd
/go/libraries/doltcore/sqle: remove AddForeignKeyToRoot
1d76f73
@coffeegoddd
/go/libraries/doltcore/sqle/ci_workflow_events.go: fix column source
34349fe
@coffeegoddd
/go/libraries/doltcore/sqle/ci_workflow_events.go: add fk name
7733302
@coffeegoddd
/go/libraries/doltcore/sqle/database.go: rm println
419b1fc
@coffeegoddd
/integration-tests/bats/ci-config.bats: add tests for foreign key vio…
b7546e5 
…lation on commit
@coffeegoddd
/integration-tests/bats/ci-config.bats: fix for remote-engine
d89c838
@coffeegoddd
/go/libraries/doltcore/sqle/enginetest: add dolt_ci_workflows engine …
81fc3ac 
…tests
@coffeegoddd
/go/libraries/doltcore/sqle/enginetest/dolt_ci_queries.go: add dolt_c…
02e1572 
…i_workflow_events engine tests
@coffeegoddd
/go/libraries/doltcore/{doltdb,sqle}: add workflows on init
19edc2d
@coffeegoddd
/go/libraries/doltcore/{doltdb,sqle}: wip, testing events table on init
63eb58b
@coffeegoddd
/go/libraries/doltcore/{doltdb,sqle}: create dolt_ci tables on dolt init
d16a5cb
@coffeegoddd
Copy link
Contributor Author

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d16a5cb ok 5937457
version total_tests
d16a5cb 5937457
correctness_percentage
100.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@jycor jycor Awaiting requested review from jycor

@zachmu zachmu Awaiting requested review from zachmu

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coffeegoddd @fulghum @jycor