Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Paired Single Move Tests #56

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Geotale
Copy link

@Geotale Geotale commented Sep 10, 2024

Adds a new file for common float tests -- This will likely be used more in the future as well
Modifies two other test files which now use functions in the CommonFloat file
The location of frsqrte_expected might change because it's not exactly common? ^^;
Adds software implementation of mantissa truncation and rounding given the expected rounding mode
Both of these are for tests for float move instructions
These instructions include:
ps_merge, ps_mr, ps_neg, ps_abs, ps_nabs
ps_rsqrte is included to check for a similar quirk (it returns an f64)
Marked as a draft until I or someone else can test on hardware (so like. a few hours if I can get it working)

Adds a new file for common float tests -- This will likely be used more in the future as well
Modifies two other tests which use thing now use functions in the CommonFloat file (the location of frsqrte_expected very well may change)
Adds software implementation of mantissa truncation and rounding given the expected rounding mode
Both of these are for tests for float move instructions
These instructions include ps_merge, ps_mr, ps_neg, ps_abs, ps_nabs, and ps_rsqrte is included to check for a similar quirk
@JosJuice
Copy link
Member

Your CommonFloat.h file is rather similar to Dolphin's Common/FloatUtils.h. I think it would be better to name the file FloatUtils.h, and to follow the approach of Dolphin's Common/FloatUtils.h where relevant (e.g. constexpr for constants instead of enums).

Will review the new hwtest in more detail once you've moved this out of draft state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants