Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/DolphinQt: Implement Emulated Balance Board. #13337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordan-woyak
Copy link
Member

Big thank you to @Pokechu22 for doing almost all of the work in #8268

I've done cleanups and final touches.

image
image
image

Any thoughts on these questions?

  • Exposing 5 Wii remote slots when only 4 can be connected is kinda weird, but I guess that's an existing issue?
  • Does "Step Off" under "Options" look fine? (it removes all weight when pressed)
  • Is 60kg default weight fine?
  • What range of weights do TASers want in the UI? (it's 0-136kg currently)

Actions like jumping or whatever can be added in another PR.

@MayImilae
Copy link
Contributor

Exposing 5 Wii remote slots when only 4 can be connected is kinda weird, but I guess that's an existing issue?

On real hardware, the balance board takes a wii remote slot right? So only 3 wii remotes can be connected while a balance board is connected? I don't have a balance board so I can't test this.

@jordan-woyak
Copy link
Member Author

Exposing 5 Wii remote slots when only 4 can be connected is kinda weird, but I guess that's an existing issue?

On real hardware, the balance board takes a wii remote slot right? So only 3 wii remotes can be connected while a balance board is connected? I don't have a balance board so I can't test this.

Yeah.

@JMC47
Copy link
Contributor

JMC47 commented Feb 6, 2025

If I remember correctly, the Wii Balance Board uses slot 4? So maybe we can just gray out slot 4 when a Balance Board is selected and put a text bubble if you hover over it that the balance board uses slot 4? Otherwise, this looks good to me.

@Pokechu22
Copy link
Contributor

IIRC there are some technical reasons for using slot 5 that I don't remember the details of (something along the lines of hardware supporting more things connected, but software rejecting it). I do remember that Marble Saga: Kororinpa supports both 4 Wii remotes and the balance board (though not at the same time; IIRC it kicks out the 4th Wii remote when you switch to balance board mode, and doesn't let you connect a balance board when not in balance board mode).

@JMC47
Copy link
Contributor

JMC47 commented Feb 6, 2025

I mean, I'm not going to split hairs over it. So if we want to do a balance board as a separate slot and still allow people to configure all four wii remotes, I'm fine with that.

@jordan-woyak
Copy link
Member Author

Yeah, the "Real Balance Board" already had the fake 5th-slot existence before this change, it's just a bit more obvious now.

@jordan-woyak jordan-woyak force-pushed the balance-board-emu branch 4 times, most recently from afd117b to 872e998 Compare February 6, 2025 22:53
@jordan-woyak
Copy link
Member Author

I'd appreciate if someone can test TAS recording/playback stuff. I only have a vague idea of how it's intended to work.

@jordan-woyak jordan-woyak force-pushed the balance-board-emu branch 2 times, most recently from 290a6cc to e1280f4 Compare February 7, 2025 03:26
@JMC47
Copy link
Contributor

JMC47 commented Feb 7, 2025

I recorded a short TAS of Wii Fit completing a body fit test, and everything worked as I expected. I was able to shift around my weight using the TAS input, there were no crashes, and everything played back correctly.

@InputEvelution
Copy link

I also did a small TAS test this morning experimenting with a couple of the balance games, and I can report that things worked correctly as well.

To answer these questions from a TASer's perspective:

  • Is 60kg default weight fine?
  • What range of weights do TASers want in the UI? (it's 0-136kg currently)
    I think that what's there is perfectly reasonable.

@jordan-woyak jordan-woyak added the WIP / do not merge Work in progress (do not merge) label Feb 8, 2025
@jordan-woyak
Copy link
Member Author

jordan-woyak commented Feb 8, 2025

Thanks for testing. I just noticed the Profiles box is showing normal Wii Remote profiles. I'll get that fixed. That's fixed now.

I'm going to try to improve the "Step On/Off" user experience.

@dolphin-ci
Copy link

dolphin-ci bot commented Feb 10, 2025

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

@Awesome-guyy
Copy link

Awesome-guyy commented Feb 10, 2025

I tested it, Balance Board emulation works!! Amazing job jordan-woyak!

It is possible to map Mouse movement if the cursor directions are mapped btw. Amazing work nontheless.

Confirmed working without any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP / do not merge Work in progress (do not merge)
Development

Successfully merging this pull request may close these issues.

6 participants