-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core/DolphinQt: Implement Emulated Balance Board. #13337
base: master
Are you sure you want to change the base?
Conversation
On real hardware, the balance board takes a wii remote slot right? So only 3 wii remotes can be connected while a balance board is connected? I don't have a balance board so I can't test this. |
Yeah. |
If I remember correctly, the Wii Balance Board uses slot 4? So maybe we can just gray out slot 4 when a Balance Board is selected and put a text bubble if you hover over it that the balance board uses slot 4? Otherwise, this looks good to me. |
IIRC there are some technical reasons for using slot 5 that I don't remember the details of (something along the lines of hardware supporting more things connected, but software rejecting it). I do remember that Marble Saga: Kororinpa supports both 4 Wii remotes and the balance board (though not at the same time; IIRC it kicks out the 4th Wii remote when you switch to balance board mode, and doesn't let you connect a balance board when not in balance board mode). |
I mean, I'm not going to split hairs over it. So if we want to do a balance board as a separate slot and still allow people to configure all four wii remotes, I'm fine with that. |
Yeah, the "Real Balance Board" already had the fake 5th-slot existence before this change, it's just a bit more obvious now. |
afd117b
to
872e998
Compare
I'd appreciate if someone can test TAS recording/playback stuff. I only have a vague idea of how it's intended to work. |
290a6cc
to
e1280f4
Compare
I recorded a short TAS of Wii Fit completing a body fit test, and everything worked as I expected. I was able to shift around my weight using the TAS input, there were no crashes, and everything played back correctly. |
I also did a small TAS test this morning experimenting with a couple of the balance games, and I can report that things worked correctly as well. To answer these questions from a TASer's perspective:
|
Thanks for testing. I just noticed the I'm going to try to improve the "Step On/Off" user experience. |
Co-authored-by: Jordan Woyak <[email protected]>
e1280f4
to
cffda24
Compare
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
I tested it, Balance Board emulation works!! Amazing job jordan-woyak! It is possible to map Mouse movement if the cursor directions are mapped btw. Amazing work nontheless. Confirmed working without any issues |
Big thank you to @Pokechu22 for doing almost all of the work in #8268
I've done cleanups and final touches.
Any thoughts on these questions?
Actions like jumping or whatever can be added in another PR.