Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump upgrade to dojo 1.3 #422

Merged
merged 1 commit into from
Mar 19, 2025
Merged

chore: bump upgrade to dojo 1.3 #422

merged 1 commit into from
Mar 19, 2025

Conversation

MartianGreed
Copy link
Collaborator

@MartianGreed MartianGreed commented Mar 19, 2025

Closes #

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Add a dedicated CI job for new examples
  • Performed self-review of the code

Summary by CodeRabbit

  • Chores
    • Documented minor version updates for several Dojo Engine packages, including an upgrade to Dojo v1.3.
    • Enhanced continuous integration by adding a step to set up a specific Rust toolchain for improved build consistency.
    • Improved the WASM package build process by streamlining command execution and cleaning up residual build files.
    • Updated the project submodule reference to incorporate the latest code improvements.

Copy link

coderabbitai bot commented Mar 19, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request adds a new changeset file that documents minor version upgrades for several Dojo Engine packages and a bump to Dojo version 1.3. The CI configuration now includes a step to set up the Rust toolchain (version 1.81.0). In the packages/torii-wasm package, the build script has been updated to use Bash and pnpx for command execution while also cleaning up temporary .gitignore files. The package’s build commands in package.json have been revised accordingly. Additionally, the commit hash for the subproject worlds/dojo-starter has been updated.

Changes

File(s) Change Summary
.changeset/healthy-sheep-draw.md Added a new markdown file documenting minor version upgrades for multiple Dojo Engine packages and a Dojo 1.3 bump.
.github/workflows/ci.yaml Introduced a new CI step using actions-rust-lang/setup-rust-toolchain@v1 with toolchain: 1.81.0 in the check job.
packages/torii-wasm/build.sh
packages/torii-wasm/package.json
Updated build.sh: switched shebang from /bin/sh to /bin/bash, changed invocation from npx to pnpx, and added cleanup for .gitignore files; modified package.json to directly execute ./build.sh for build:wasm and added a new build script using pnpm.
worlds/dojo-starter Updated the subproject commit hash from 0c97b2… to 7f6450….

Sequence Diagram(s)

sequenceDiagram
    participant Runner as GitHub Runner
    participant CI as GitHub Actions Workflow
    Runner->>CI: Trigger CI Workflow
    CI->>CI: Run Pre-check Steps
    CI->>CI: Setup Rust Toolchain (v1.81.0)
    CI->>Runner: Execute Remaining Steps
    Runner-->>CI: Job Completion
Loading
sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager (pnpm)
    participant BS as build.sh Script
    participant WP as wasm-pack
    Dev->>PM: Run "pnpm build" command
    PM->>BS: Invoke "./build.sh"
    BS->>WP: Execute pnpx wasm-pack commands (Web & Node)
    BS->>BS: Remove .gitignore in ../pkg/web
    BS-->>PM: Build Process Complete
Loading

Possibly related PRs

Suggested reviewers

  • ponderingdemocritus

Poem

I'm a hopping rabbit, skipping through code,
In shells and scripts, my joy brightly glowed.
Bash now leads the dance with a pnpx spin,
CI and cleanups join—oh, what a win!
Minor bumps and hashes, a rhythmic delight,
Celebrating fresh changes with every byte!
🐇💻 Hop on, fellow coders, into the night!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42dbf97 and 5e23a94.

📒 Files selected for processing (5)
  • .changeset/healthy-sheep-draw.md (1 hunks)
  • .github/workflows/ci.yaml (1 hunks)
  • packages/torii-wasm/build.sh (2 hunks)
  • packages/torii-wasm/package.json (1 hunks)
  • worlds/dojo-starter (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MartianGreed MartianGreed force-pushed the chore/bump-dojo-1.3 branch 3 times, most recently from b72c3e0 to 589c458 Compare March 19, 2025 10:17
@MartianGreed MartianGreed marked this pull request as ready for review March 19, 2025 10:43
@MartianGreed MartianGreed merged commit 4d7d531 into main Mar 19, 2025
3 of 5 checks passed
@MartianGreed MartianGreed deleted the chore/bump-dojo-1.3 branch March 19, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant