Try removing quotes #6501
Merged
Try removing quotes #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If that works: Please target 3.9.x. |
|
OK. FTR I'm not very hopeful it will fix the issue, but I've been wrong before. |
|
🤯 🤯 🤯 why does it work?!? I'm rebasing. |
I have been told it could fix the issue we have with Codecov. Let us try the suggestion before reporting a new issue.
greg0ire
force-pushed
the
try-removing-quotes
branch
from
07fbe40
to
44c5169
Compare
derrabus
approved these changes
Aug 15, 2024
derrabus
added a commit
that referenced
this pull request
Aug 15, 2024
* 3.9.x: Try removing quotes (#6501)
derrabus
added a commit
that referenced
this pull request
Aug 15, 2024
* 4.2.x: Try removing quotes (#6501)
|
It seems that it still fails, it's just that it fails randomly: https://github.com/doctrine/dbal/actions/runs/10426300024/job/28890873426?pr=5897 I will open another ticket on Codecov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been told it could fix the issue we have with Codecov. Let us try the suggestion before reporting a new issue.