Merge 3.9.x and 4.0.x into 4.1.x #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rine#6435) <!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | improvement | Fixed issues | doctrine#6433 #### Summary Nightly cron scheduled alternate to doctrine#6433.
Merge 3.8.x up into 4.0.x
ci: nightly - php-8.1 only + workflow_dispatch
Old approach no longer works in DBAL 4 Closes doctrine#6354, closes doctrine#6459
I asked internally how it is supposed to end, and got the answer straight from the horse's mouth.
Complete sentence
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | bug/improvement | Fixed issues | Incorrect & inconsistent QueryBuilder documentation for aliases in update/delete #### Summary In doctrine#6394 the documentation was partially updated to remove aliases for the documentation for the update method, as the separate parameter for it was removed in the upgrade from 3.x to 4.x. Inline aliasing is still possible, and I suspect this was the reason the extra parameter was removed. ( `->update('users alias1', 'alias2')`)? This PR readds the alias to the documentation for the occurences in the linked PR, and also updates the other occurences in docblocks + the online documentation.
MySQL 9 has been released and 8.4 has been declared to be the LTS release. I've added MySQL 9 to the test matrix and took the opportunity to shrink the test matrix a little. Our CI is othen blocked because of too many concurrent jobs, so we might not want to test all possible permutations of PHP and MySQL versions. Taking into account that we're going to maintain the 3.x branch for a little longer, we need a strategy for not letting the test matrix grow exponentially with every future PHP or DBMS release. My proposal for MySQL: * Test all supported MySQL versions (currently: 5.7, 8.0, 8.4, 9.0) with the latest PHP version (currently 8.3). * Test the oldest supported PHP release (currently 7.4) against one release only (MySQL 8.0) only. All other PHP releases are tested against SQLite already. If this proposal is accepted, I'd like to work out a similar strategy for the other supported DBMS. I think we should also document that strategy properly then.
| Q | A |------------- | ----------- | Type | improvement | Fixed issues | Prevents future issues ;-) #### Summary PHP 8.4 will support a new error code 4031 in mysqlnd when the connection is dropped due to timeouts. It has been introduced in: mysql/mysql-server@14508bb And PHP 8.4 will support it: php/php-src#13618 The PR gets the test suite green again (mysqli + pdo_mysql). I have used 4.0.x as base, but feel free to change according to your preferences.
* 3.8.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Complete sentence mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
* 3.8.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Complete sentence
* 4.0.x: Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363) CI: Add MySQL 9, reduce test matrix (doctrine#6462) Fix update/delete aliases in documentation (doctrine#6470) Complete sentence Docs: update custom platform example to use middlewares (doctrine#6460) ci: nightly - php-8.1 only + workflow_dispatch ci: nightly - php-8.1 min version (doctrine#6457) mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
* 3.9.x:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.