Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues with migration of HTML content to Content Workflow #6450

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

tvatavuk
Copy link

More robust migration, Fixes #6429.

Summary

The new stored procedure CreateMissingContentWorkflows will ensure that missing workflows and states are populated before running the migration from the old HTML workflows to the new ContentWorkflow model. Once this step is complete, the MigrateHtmlWorkflows procedure will execute, which includes a more robust migration process for mapping old workflow state IDs to the new system.

@valadas valadas added this to the 10.0.0 milestone Mar 13, 2025
@tvatavuk
Copy link
Author

No code changes in this commit—just Git maintenance to ensure a clean history after a commit from another PR briefly appeared here.

@valadas valadas changed the title Fix #6429 Migration of HTML content to Content Workflow does not work for some sites Fixed issues with migration of HTML content to Content Workflow Mar 14, 2025
@tvatavuk tvatavuk force-pushed the release/10.0.0 branch 2 times, most recently from 530ad7e to cfd74ec Compare March 17, 2025 17:42
@tvatavuk
Copy link
Author

Last commit focuses on cleaning up deprecated functionality and unused files, including updates to the SQL schema. These elements were no longer in use and have been safely removed to streamline the codebase and improve maintainability.

Key Notes:

  • The changes do not impact the functionality of the HTML module.
  • The cleanup includes the removal of legacy code and database elements that are no longer relevant.

Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the sites I was testing the upgrade with had a object qualifier in use, which demonstrated that this script is missing/misplacing a few {objectQualifier} tokens. I've added suggestions for most of them, but there was one place where GitHub wouldn't let me add it. I can push that change up in a different way.

BEGIN
DROP PROCEDURE {databaseOwner}{objectQualifier}GetHtmlTextLog;
END
DROP PROCEDURE {databaseOwner}{objectQualifier}GetHtmlTextLog;
GO

-- Create Procedure GetHtmlTextLog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table aliases in the SELECT list in this procedure and the next need to include {objectQualifier}

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the updated scripts and this appears to be working for my sites as well.

@mitchelsellers mitchelsellers merged commit 1304185 into dnnsoftware:release/10.0.0 Mar 24, 2025
3 checks passed
@tvatavuk
Copy link
Author

Thank you @bdukes for ensuring successful integration!
Huge thanks to @bdukes and @mitchelsellers for your dedication and collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants