-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues with migration of HTML content to Content Workflow #6450
Fixed issues with migration of HTML content to Content Workflow #6450
Conversation
1b2fcaa
to
055d50b
Compare
No code changes in this commit—just Git maintenance to ensure a clean history after a commit from another PR briefly appeared here. |
…es not work for some sites
530ad7e
to
cfd74ec
Compare
Last commit focuses on cleaning up deprecated functionality and unused files, including updates to the SQL schema. These elements were no longer in use and have been safely removed to streamline the codebase and improve maintainability. Key Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the sites I was testing the upgrade with had a object qualifier in use, which demonstrated that this script is missing/misplacing a few {objectQualifier}
tokens. I've added suggestions for most of them, but there was one place where GitHub wouldn't let me add it. I can push that change up in a different way.
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
BEGIN | ||
DROP PROCEDURE {databaseOwner}{objectQualifier}GetHtmlTextLog; | ||
END | ||
DROP PROCEDURE {databaseOwner}{objectQualifier}GetHtmlTextLog; | ||
GO | ||
|
||
-- Create Procedure GetHtmlTextLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The table aliases in the SELECT
list in this procedure and the next need to include {objectQualifier}
DNN Platform/Modules/HTML/Providers/DataProviders/SqlDataProvider/10.00.00.SqlDataProvider
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the updated scripts and this appears to be working for my sites as well.
Thank you @bdukes for ensuring successful integration! |
More robust migration, Fixes #6429.
Summary
The new stored procedure CreateMissingContentWorkflows will ensure that missing workflows and states are populated before running the migration from the old HTML workflows to the new ContentWorkflow model. Once this step is complete, the MigrateHtmlWorkflows procedure will execute, which includes a more robust migration process for mapping old workflow state IDs to the new system.