-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loky to 3.5.1. #11341
Update loky to 3.5.1. #11341
Conversation
Still getting the same error in mgpu? |
Need to freeze CPU env as well. |
It seems I couldn't freeze loky on CPU CI:
|
Found the definition in the devop repo. Will freeze loky there. We need a way to unify the dependencies between the main repo and the devop repo. |
cc @hcho3 All tests pass. |
JFYI Maybe worth testing if that fixed the issue |
Thank you for sharing! We still need a conda update before we can use it on CI. |
Should be available now |
Updated to loky 3.5.1. All tests pass. Thank you, @jakirkham, for sharing and the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad this is working Jiaming! 😀
Had a minor suggestion below
@@ -26,7 +26,7 @@ dependencies: | |||
- awscli | |||
- numba | |||
- llvmlite | |||
- loky | |||
- loky>=3.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of requiring latest, we could simply disallow the problematic version
This could also be done in setup.py
and other environment files
- loky>=3.5.1 | |
- loky!=3.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion! I think I would like to keep it as the latest for the CI, it's only used by the tests and we don't want to deal with more than one version in the CI.
macos hang https://github.com/dmlc/xgboost/actions/runs/13872185297/job/38820191876 .
mgpu test error: https://github.com/dmlc/xgboost/actions/runs/13898762098/job/38886026698?pr=11339
Ref dmlc/xgboost-devops#15 .