Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loky to 3.5.1. #11341

Merged
merged 15 commits into from
Mar 19, 2025
Merged

Update loky to 3.5.1. #11341

merged 15 commits into from
Mar 19, 2025

Conversation

@trivialfis trivialfis changed the title [Don't merge] Test macos hang. Freeze loky on macos. Mar 15, 2025
@trivialfis trivialfis requested a review from hcho3 March 15, 2025 19:03
@trivialfis trivialfis changed the title Freeze loky on macos. Freeze loky to 3.4.1. Mar 17, 2025
@trivialfis trivialfis closed this Mar 17, 2025
@trivialfis trivialfis reopened this Mar 17, 2025
@hcho3
Copy link
Collaborator

hcho3 commented Mar 17, 2025

Still getting the same error in mgpu?

@trivialfis
Copy link
Member Author

trivialfis commented Mar 18, 2025

Need to freeze CPU env as well.

@trivialfis
Copy link
Member Author

It seems I couldn't freeze loky on CPU CI:

2025-03-18T07:41:51.2845518Z 
2025-03-18T07:41:51.2845721Z =================================== FAILURES ===================================
2025-03-18T07:41:51.2846380Z ___________________________ test_rabit_communicator ____________________________
2025-03-18T07:41:51.2846861Z 
2025-03-18T07:41:51.2847019Z     @pytest.mark.skipif(**tm.no_loky())
2025-03-18T07:41:51.2847538Z     def test_rabit_communicator() -> None:
2025-03-18T07:41:51.2848015Z         import loky
2025-03-18T07:41:51.2848395Z         from loky import get_reusable_executor
2025-03-18T07:41:51.2848853Z     
2025-03-18T07:41:51.2849167Z >       assert loky.__version__ == "3.4.1"
2025-03-18T07:41:51.2849892Z E       AssertionError: assert '3.5.0' == '3.4.1'
2025-03-18T07:41:51.2850319Z E         
2025-03-18T07:41:51.2850582Z E         - 3.4.1
2025-03-18T07:41:51.2850860Z E         + 3.5.0
2025-03-18T07:41:51.2851043Z 
2025-03-18T07:41:51.2851564Z tests/python/test_collective.py:30: AssertionError

@trivialfis
Copy link
Member Author

Found the definition in the devop repo. Will freeze loky there. We need a way to unify the dependencies between the main repo and the devop repo.

@trivialfis trivialfis closed this Mar 18, 2025
@trivialfis trivialfis reopened this Mar 18, 2025
@trivialfis
Copy link
Member Author

cc @hcho3 All tests pass.

@jakirkham
Copy link
Contributor

JFYI loky just released 3.5.1

Maybe worth testing if that fixed the issue

@trivialfis
Copy link
Member Author

Thank you for sharing! We still need a conda update before we can use it on CI.

@trivialfis
Copy link
Member Author

@jakirkham
Copy link
Contributor

Should be available now

xref: conda-forge/loky-feedstock#31

@trivialfis trivialfis closed this Mar 19, 2025
@trivialfis trivialfis reopened this Mar 19, 2025
@trivialfis trivialfis changed the title Freeze loky to 3.4.1. Update loky to 3.5.1. Mar 19, 2025
@trivialfis
Copy link
Member Author

Updated to loky 3.5.1. All tests pass. Thank you, @jakirkham, for sharing and the help!

Copy link
Contributor

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad this is working Jiaming! 😀

Had a minor suggestion below

@@ -26,7 +26,7 @@ dependencies:
- awscli
- numba
- llvmlite
- loky
- loky>=3.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of requiring latest, we could simply disallow the problematic version

This could also be done in setup.py and other environment files

Suggested change
- loky>=3.5.1
- loky!=3.5.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion! I think I would like to keep it as the latest for the CI, it's only used by the tests and we don't want to deal with more than one version in the CI.

@trivialfis trivialfis merged commit 62bae0f into dmlc:master Mar 19, 2025
74 of 75 checks passed
@trivialfis trivialfis deleted the test-macos-timeout branch March 19, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants