New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

741 otp #747

Merged

AlexNi245 merged 20 commits into develop from 741-otp

Feb 9, 2024

Collaborator

Bhupesh-mfsi commented Feb 7, 2024

Email verification OTP

Bhupesh-mfsi added 12 commits

January 29, 2024 15:09


          add notification channel

13b3545


          Merge branch 'develop' of https://github.com/corpus-io/dm3 into 739-n…

ab4f887

…otification-apis


          added test cases for notification API's

otp


          PR changes

885cf69


          Merge branch '739-notification-apis' of https://github.com/corpus-io/dm3

e49db95

 into 741-otp


          email verification OTP

157abb2


          resolved conflicts

ff5390a


          email verification OTP

a44dafa


          removed email credentials from default properties

286caab


          updated comments

bd40a54


          added default email config in delivery properties

17c1acd

Bhupesh-mfsi requested a review from AlexNi245

February 7, 2024 11:12

AlexNi245 reviewed

View reviewed changes

packages/backend/src/config/getDeliveryServiceProperties.test.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/backend/src/config/getDeliveryServiceProperties.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/backend/src/notifications.ts Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/backend/src/persistance/getDatabase.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/backend/src/persistance/otp/setOtp.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/Notification.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/Notification.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/Notifications.test.ts Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/broker/NotificationBroker.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/broker/NotificationBroker.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/getEmailTemplate.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/templates/otp.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/templates/otp.ts Show resolved Hide resolved

AlexNi245 requested changes

View reviewed changes

Collaborator

AlexNi245 left a comment

see comments

Collaborator Author

Bhupesh-mfsi commented Feb 7, 2024

see comments

ok

Bhupesh-mfsi added 2 commits

February 8, 2024 00:52


          added few more test cases & did few optimizations

8eacde5


          fixed test cases getting failed

AlexNi245 reviewed

View reviewed changes

packages/lib/delivery/src/notifications/broker/NotificationBroker.ts Outdated Show resolved Hide resolved

AlexNi245 requested changes

View reviewed changes

Collaborator

AlexNi245 left a comment

see comments

Bhupesh-mfsi added 5 commits

February 8, 2024 14:27


          changes done as per comment

7ec0392


          added channel not supported error

5348b70


          fixed test cases

c684a96


          resolved conflicts

5a834b2


          Merge branch 'develop' of https://github.com/corpus-io/dm3 into 741-otp

c55360a

AlexNi245 reviewed

View reviewed changes

packages/backend/src/notifications.ts Outdated Show resolved Hide resolved

AlexNi245 reviewed

View reviewed changes

packages/backend/src/index.ts Outdated Show resolved Hide resolved

AlexNi245 requested changes

View reviewed changes

Collaborator

AlexNi245 left a comment

Please use the deliveryServiceValue instead of a function as an arugument for Notifications


          added DS properties as parameter in notification

e5ce076

Bhupesh-mfsi requested a review from AlexNi245

February 9, 2024 06:03

Collaborator Author

Bhupesh-mfsi commented Feb 9, 2024

Please use the deliveryServiceValue instead of a function as an arugument for Notifications

Done

Bhupesh-mfsi closed this

Bhupesh-mfsi reopened this

Collaborator Author

Bhupesh-mfsi commented Feb 9, 2024

Please use the deliveryServiceValue instead of a function as an arugument for Notifications

Done

AlexNi245 approved these changes

View reviewed changes

AlexNi245 merged commit ea0ce14 into develop

12 checks passed

AlexNi245 deleted the 741-otp branch

February 9, 2024 08:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet