Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade libdparse #965

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WebFreak001
Copy link
Member

adds support for interpolated strings

@rikkimax
Copy link
Contributor

rikkimax commented Mar 1, 2025

I don't understand how this is passing.

    Cleaning artifacts for package dscanner at C:\Users\alpha\AppData\Local\dub\cache\dscanner\0.16.0-beta.4+commit.18.g3a87c65
   Upgrading project in Q:\Misc Software\D-Dev-Tools\D-Scanner\
     Warning Warning: License in sub-package dcd:dsymbol is different than its parent package, this is discouraged.
    Starting Performing "release" build using ldc2 for x86_64.
  Up-to-date emsi_containers 0.9.0: target for configuration [library] is up to date.
    Building libdparse 0.25.0: building configuration [library]
    Building dcd:dsymbol 0.16.0-beta.3: building configuration [library]
  Up-to-date inifiled 1.3.3: target for configuration [library-quiet] is up to date.
  Up-to-date libddoc:common 0.8.0: target for configuration [library] is up to date.
    Building libddoc 0.8.0: building configuration [lib]
    Building dscanner 0.16.0-beta.4+commit.18.g3a87c65: building configuration [application]
   Pre-build Running commands
src\dscanner\analysis\mismatched_args.d(56,52): Error: no property `argNames` for `sym` of type `const(dsymbol.symbol.DSymbol)*`

https://github.com/dlang-community/D-Scanner/blob/master/src/dscanner/analysis/mismatched_args.d#L56

Offending PR: dlang-community/DCD#763

@rikkimax
Copy link
Contributor

rikkimax commented Mar 1, 2025

@LightBender
Copy link

Are we waiting on anything to merge this?

@rikkimax
Copy link
Contributor

rikkimax commented Mar 6, 2025

Apart from the fact that if we did merge it, people who are not me are going to complain about it being broken?

Clone it, run dub upgrade on it, and try to build it. Just watch.

@pbackus
Copy link

pbackus commented Mar 6, 2025

DCD has already been updated upstream, so we should be good to go here once we upgrade the submodule and dub.json, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants