Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Fira Mono" font assets #1879

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamzap
Copy link
Member

@adamzap adamzap commented Jan 18, 2025

  • Upgraded to the latest version
  • Used woff2 format instead of woff

The files were fetched from GitHub: https://github.com/mozilla/Fira/tree/master/woff2.

There's not much space savings here, but I think it's still worth upgrading.

This change can be verified by checking that the new files are being loaded in the DevTools network panel:

image

Another way verify this change is observing that certain glyphs are updated to match the hosted version here. Note the "r":

Hosted (new):

image

Old:

image

New:

image

Refs #1815

- Upgraded to the latest version
- Used `woff2` format instead of `woff`

The files were fetched from GitHub:
https://github.com/mozilla/Fira/tree/master/woff2.
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants