Added latest DSF board meeting minutes to complementary sidebar. #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
force-pushed
the
dsf-meeting-minutes
branch
from
3118018 to
9dac75e
Compare
bmispelon
reviewed
Jan 17, 2025
foundation/tests.py
Outdated
| @@ -77,3 +77,49 @@ def test_meeting_details(self): | |||
| self.assertContains(response, "DSF Board monthly meeting") | |||
| self.assertContains(response, "USD $10,000.00") | |||
| self.assertContains(response, "EUR €5,000.00") | |||
|
|
|||
| def test_latest_meeting_minutes(self): | |||
| user = User.objects.create_superuser("admin", "[email protected]", "password") | |||
There was a problem hiding this comment.
All 4 tests in this file now create the same user object. Can we move it to a setUpTestData on the class instead?
There was a problem hiding this comment.
Good point 👍 moved member into setUpTestData as well as it's need in 3/4 tests
sarahboyce
force-pushed
the
dsf-meeting-minutes
branch
from
9dac75e to
8ca5bd9
Compare
sarahboyce
force-pushed
the
dsf-meeting-minutes
branch
from
9f6cd5b to
9b44b54
Compare
|
Nice work, thanks! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1870
