Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1727 -- Retire django-developers and django-users mailing list #1805

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

ontowhee
Copy link
Contributor

@ontowhee ontowhee commented Dec 8, 2024

Fix for #1727

I've removed the references to the mailing lists. I hope it looks good!

Footer

Before
footer-mailing-list-before

After
footer-mailing-list-after

Community

Before
community-mailing-list-before

After
community-mailing-list-after

Download page

Before
download-mailing-list-before

After
download-mailing-list-after

Homepage

Before
homepage-mailing-list-before

After
homepage-mailing-list-after

Contact Foundation

Before
foundation-before

After
foundation-after

Docs Template Sidebar

Before
sidebar-before

After
sidebar-after

Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, thanks for working on this 🙇🏻

Using git grep mailing.list I found more places that should be fixed:

  • djangoproject/templates/contact/foundation.html
  • docs/templates/docs/doc.html

There's also things inside djangoproject/templates/conduct/ that should be updated, but I don't know if that requires approval from the CoC work group. I'll ask around, we can do it in a separate PR later.

@ontowhee
Copy link
Contributor Author

ontowhee commented Dec 8, 2024

I've updated djangoproject/templates/contact/foundation.html and docs/templates/docs/doc.html. Thanks for mentioning these! I've added their screenshots to the PR description.

@ontowhee ontowhee requested a review from bmispelon December 8, 2024 14:48
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, nice work 👍🏻

Thanks for taking the time to take screenshots too, it made reviewing even easier 🙇🏻

@bmispelon bmispelon merged commit aef8578 into django:main Dec 8, 2024
4 checks passed
@thibaudcolas
Copy link
Member

Thank you! 😌 Now we have to figure out what to do with all that space on the homepage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants