You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please describe the changes this PR makes and why it should be merged:
I noticed ownerId was missing from PartialGroupDMChannel. This PR fixes that.
While looking at the api documentation alone, it is hard to determine for me if the owner_id can be missing for Group DM Channel's, but from my testing so far, I found it to be always present. So taking that at face value
Status and versioning classification:
Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
While looking at the api documentation alone, it is hard to determine for me if the owner_id can be missing for Group DM Channel's, but from my testing so far, I found it to be always present. So taking that at face value
owner_id? has been optional since before threads were added, I think you should leave it as such
Yeah it's optional because it can be missing for other channel types, my thinking was it would always be present for GroupDMs, but now that you mention it, looking at other djs structures (ThreadChannel) it accounts for that. So I think I should stick to the library behavior
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vladfrangu
changed the title
imnaiyar
force-pushed
the
fix/missing-owner-id
branch
from
Please describe the changes this PR makes and why it should be merged:
I noticed
ownerIdwas missing fromPartialGroupDMChannel. This PR fixes that.While looking at the api documentation alone, it is hard to determine for me if the
owner_idcan be missing for Group DM Channel's, but from my testing so far, I found it to be always present. So taking that at face valueStatus and versioning classification: