feat(InteractionResponses): support with_response query parameter #10499
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
We'll wait for #10488 before this one lands. |
Co-authored-by: Jiralite <[email protected]>
packages/discord.js/src/structures/InteractionCallbackResponse.js
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10499 +/- ##
==========================================
+ Coverage 35.48% 35.49% +0.01%
==========================================
Files 228 228
Lines 14308 14303 -5
Branches 1254 1254
==========================================
Hits 5077 5077
+ Misses 9187 9182 -5
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Please resolve conflicts! |
| this.interaction = new InteractionCallback(client, data.interaction); | ||
|
|
||
| /** | ||
| * The resource that was created by the interaction response |
There was a problem hiding this comment.
| * The resource that was created by the interaction response | |
| * The resource that was created by the interaction response |
| /** | ||
| * The id of the channel the original interaction was sent in | ||
| * @type {?Snowflake} | ||
| */ | ||
| this.channelId = data.channel_id ?? null; | ||
|
|
||
| /** | ||
| * The id of the guild the original interaction was sent in | ||
| * @type {Snowflake} | ||
| */ | ||
| this.guildId = data.guild_id ?? null; |
There was a problem hiding this comment.
These properties appear to be undocumented. I believe they should be removed, if I'm not mistaken.
https://discord.com/developers/docs/interactions/receiving-and-responding#interaction-callback-interaction-callback-object
Please describe the changes this PR makes and why it should be merged:
Closes #10498
/core done in #10512
Upstream: discord/discord-api-docs#7106
Status and versioning classification: