Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump guide node 18 #10492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ICEPrey
Copy link

@ICEPrey ICEPrey commented Sep 7, 2024

Please describe the changes this PR makes and why it should be merged:

Changes Made

  1. Updated the minimum required Node.js version for discord.js v14 from v16.11.0 to v18.20.4 on the guide.
  2. Modified the version check example in the tip section, changing the version number from v16.11.0 to v18.20.4.

Reasons for Merging

  1. Documentation Accuracy: Keeps the documentation up-to-date with the current requirements for using discord.js v14.
  2. Best Practices: Aligns with current best practices by recommending a more recent LTS version of Node.js.
  3. User Experience: Helps prevent potential issues users might encounter when trying to use discord.js with an outdated Node.js version.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2024 2:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 7, 2024 2:02am

@vladfrangu
Copy link
Member

Imo for the guide we should guide people towards newer LTS versions, even if libraries may support older ones. Node 18 is set to become EoL this october if memory serves, might as well document node 20 here

@ICEPrey
Copy link
Author

ICEPrey commented Sep 7, 2024

Got it will do tomorrow.

@almeidx
Copy link
Member

almeidx commented Sep 7, 2024

I'm not sure this guide is supposed to receive updates, cc: @iCrawl

Either way, Node.js v18 becomes end-of-life on 2025-04-30, not this october
If we're going to update this, might as well use Node.js v22 which starts LTS at 2024-10-29, <2 months away (Node.js v20 goes into maintenance a day after that)

@ICEPrey
Copy link
Author

ICEPrey commented Sep 7, 2024

I'm not sure this guide is supposed to receive updates, cc: @iCrawl

Either way, Node.js v18 becomes end-of-life on 2025-04-30, not this october If we're going to update this, might as well use Node.js v22 which starts LTS at 2024-10-29, <2 months away (Node.js v20 goes into maintenance a day after that)

Oh ok so before proceeding, I'd like to address a couple of points

@almeidx: Thank you for the correction on Node.js v18's end-of-life date and the suggestion for v22. You've raised an important question about whether this guide is supposed to receive updates

@iCrawl: Could you please clarify if this guide is meant to receive regular updates?

If the guide is supposed to get regular updates, are we suppose to update the minimum required Node.js version from v16.11.0 to v22.8.0 (Current version). Or should we prioritize the Current version (v22.8.0) or the LTS version (v20.17.0) in our recommendations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants