Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(voice): Add vitest #10472

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

test(voice): Add vitest #10472

wants to merge 9 commits into from

Conversation

nyapat
Copy link
Contributor

@nyapat nyapat commented Sep 2, 2024

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

@nyapat nyapat requested a review from a team as a code owner September 2, 2024 13:00
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 0:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2024 0:56am

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (495bc60) to head (523231f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10472      +/-   ##
==========================================
+ Coverage   35.48%   38.16%   +2.68%     
==========================================
  Files         228      227       -1     
  Lines       14308    15180     +872     
  Branches     1254     1401     +147     
==========================================
+ Hits         5077     5794     +717     
- Misses       9187     9374     +187     
+ Partials       44       12      -32     
Flag Coverage Δ
brokers 31.44% <ø> (ø)
builders 91.58% <ø> (ø)
collection 100.00% <ø> (ø)
formatters 97.43% <ø> (ø)
guide 0.54% <ø> (ø)
proxy 66.27% <ø> (ø)
rest 87.37% <ø> (ø)
util 41.42% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 72.23% <ø> (+8.58%) ⬆️
website 0.00% <ø> (ø)
ws 36.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite changed the title feat(voice): vitest test(voice): Add vitest Sep 8, 2024
@Jiralite Jiralite added the tests label Sep 8, 2024
@vladfrangu
Copy link
Member

Can you try to rebase your PR? Just start the rebase, and every time you get a merge issue on pnpm-lock.yaml, just run pnpm i. It'll solve itself

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a vitest config file for this too 🙏 Personally don't like relying on defaults

@nyapat
Copy link
Contributor Author

nyapat commented Sep 9, 2024

Can you add a vitest config file for this too 🙏 Personally don't like relying on defaults

Is what I've done okay? It falls back to the config in the monorepo top level, and nothing else is currently needed, but there so that it may be edited if needed

@vladfrangu
Copy link
Member

Turns out only rest has a custom vitest.config.ts file 🥴. It's fine as is 🫡

packages/voice/package.json Outdated Show resolved Hide resolved
packages/voice/package.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

4 participants