-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(voice): mark stream as ended #10455
base: main
Are you sure you want to change the base?
Conversation
refactor: prefer destroying the stream
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible, can we get a test script for this too? 🙏
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10455 +/- ##
===========================================
+ Coverage 38.01% 50.44% +12.43%
===========================================
Files 239 227 -12
Lines 15471 20742 +5271
Branches 1353 1305 -48
===========================================
+ Hits 5881 10463 +4582
- Misses 9575 10267 +692
+ Partials 15 12 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
drafted because putting tests was a good idea and i found undesirable behaviour (particularly annoying because the tests & actual context of the function don't align properly) |
test: wait duration ms to check end chore: eslint test: end before timeout
26a051a
to
d6a380e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering voice is an "if may work" basis, and assuming you've tested this with actual discord behavior, LGTM
Please describe the changes this PR makes and why it should be merged:
closes #8778
example:
Status and versioning classification: