chore: improve README.md layout with badges and colors #10428
Conversation
Enhanced the README.md file by adding the npm logo and two new badges: the last commit and contributions badges. These additions help viewers and coders understand the latest commit activity and the number of contributors. Updated the badge colors to better contrast and look more appealing than the previous ones.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
nsgpriyanshu
requested review from
didinele,
Jiralite and
ckohen
and removed request for
a team
Co-authored-by: Almeida <[email protected]>
Okay 👍 |
| <a href="https://github.com/discordjs/discord.js/commits/main"><img src="https://img.shields.io/github/last-commit/discordjs/discord.js.svg?maxAge=3600&logo=github&logoColor=fff" alt="last commit" /></a> | ||
| <a href="https://github.com/discordjs/discord.js/graphs/contributors"><img src="https://img.shields.io/github/contributors/discordjs/discord.js.svg?maxAge=3600&logo=github&logoColor=fff&color=00c7be" alt="contributors" /></a> |
There was a problem hiding this comment.
Is it me, or do I feel this is misleading to put in the discord.js package? It would be fine on the root README.md. Imagine if the most recent commit was to brokers... that's not a commit to here.
There was a problem hiding this comment.
Yes, but @vladfrangu told me to add it to all packages.
There was a problem hiding this comment.
I'd like to see this addressed before merging. Vlad probably didn't realize
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10428 +/- ##
==========================================
+ Coverage 38.00% 38.03% +0.02%
==========================================
Files 239 239
Lines 15488 15464 -24
Branches 1367 1353 -14
==========================================
- Hits 5886 5881 -5
+ Misses 9587 9568 -19
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please describe the changes this PR makes and why it should be merged:
This pull request enhances the
README.mdfile by introducing the npm logo and two new badges: one for the last commit and one for contributions. These additions provide viewers and contributors with clear information on the latest commit activity and the number of contributors. The badge colors have also been updated for improved contrast and visual appeal, creating a more attractive and informative layout compared to the previous version.Status and versioning classification: